feat(RoomClient): implement forward participant api#618
Closed
feat(RoomClient): implement forward participant api#618
Conversation
Contributor
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
theomonnom
approved these changes
Apr 4, 2025
Member
Author
|
@theomonnom need some help here, the errors are because of the new changes here: https://github.com/livekit/protocol/blob/main/protobufs/livekit_sip.proto#L480-L512 But, it still shows me a missing fields error when I try not to set the deprecated fields. How is this handled usually? |
Member
Author
|
Another small change that this PR needs before it goes out: livekit/node-sdks#460 |
anunaym14
force-pushed
the
feat/forward-participant
branch
from
ea49dff to
1fe385e
Compare
Member
Author
|
Closing in favor of #641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are failing due an unrelated SIP proto update. Keeping this PR as a draft, will fix in a bit.